Ticket #7 (closed Feature Request: fixed)

Opened 14 years ago

Last modified 9 years ago

Refactor MainUI / Smarty templates usage

Reported by: benoitg Owned by: benoitg
Priority: normal Milestone: WifiDog Auth Server 1.0
Component: Auth server, Code Refactoring Version: Auth Server SVN
Keywords: Cc:

Change History

Changed 14 years ago by fproulx

Logged In: YES 
user_id=1245118

Should'nt this RFE be changed for "Refactor MainUI / Smarty templates 
usage", kinda.

Changed 14 years ago by fproulx

  • summary changed from Remove Smarty support to Refactor MainUI / Smarty templates usage

Changed 14 years ago by MaxHorvath

  • component changed from Auth server: Code Refactoring to Auth server: Code Refactoring

Well, instead of removing Smarty support we should be removing every HTML from our PHP code!

Changed 14 years ago by fproulx

  • milestone set to WifiDog 1.0

Changed 14 years ago by benoitg

  • version For 1.0 deleted
  • description modified (diff)

The final decision was that the refactoring would be done by using a Smarty to create "MacroTemplate?" where it makes sense to do so. Despite this decision, the goal isn't for every group to use custom templates. The "normal" channel for customisation will be (once implemented): -Custom CSS (a simple theming engine will built into wifdog to allow this) -Support for placing Content blocks in predefined areas.

To make this possible, the following will progressively be done: -Move all layout to CSS everytime it is technically possible to do so. -Rewriting some interface elements as "static" Content objects. -Improve the content management, but retaining the "WifiDog is a content presentation tool, not a content creation tool" philosophy.

So, "It makes sense to move html to Smarty template" was defined as "When it will improve maintenance", and more specifically meets one of the following criterias -It's likely a group would have to make changes to the HTML because there are currently no other mechanism to support customisation that is likely to be required. -All the HTML in a single php script was 100% presentation (In a MVC sense) -The template even if small contains HTML reused in lots of places.

The goal is NOT to remove all HTML for PHP files "just because I read it's more professional". You need a proper justification to create a very small template that wouldn't contain any significant presentation logic.

The goal is to arrive to about 30 templates total for the entire system.

Changed 14 years ago by max-horvath

I agree ...

What I'd like to know if we can start to work on this issue or if we should still wait for Dana being ready with his work?

If he needs more time, maybe we should already start to refactor the code ... I'm pretty sure, implementing the new layout (I mean no CSS-layout) would also be much easier then ...

Changed 14 years ago by max-horvath

  • owner changed from nobody to max-horvath
  • status changed from assigned to new
  • version set to Auth Server SVN

Almost done with it ... so I'll accept the ticket ...

Changed 14 years ago by max-horvath

  • status changed from new to assigned

Changed 14 years ago by max-horvath

  • owner max-horvath deleted
  • status changed from assigned to new

Changed 13 years ago by benoitg

  • owner set to benoitg

Changed 13 years ago by fproulx

  • status changed from new to closed
  • resolution changed from None to fixed

Changed 13 years ago by benoitg

  • component changed from Auth server: Code Refactoring to Auth server, Code Refactoring

Changed 9 years ago by jodoreps

  • description modified (diff)
Note: See TracTickets for help on using tickets.