Ticket #484 (closed Bug report: wontfix)

Opened 9 years ago

Last modified 9 years ago

httpd content using ACL preload will segfault in libhttpd/api.c

Reported by: tj@… Owned by:
Priority: lowest Milestone: Not yet assigned to a Milestone
Component: Gateway Version:
Keywords: Cc:

Description

Line 979 of libhttpd/api.c being

if ((entry->preload)(server) < 0)

should be

if ((entry->preload)(server, r) < 0)

This has no effect on the current standard codebase since there is no preload function defined, and it doesn't appear that ACL's in libhttpd are even utilized by wifidog. However, for others that may use this feature in a custom build or for future development reference I figure this may be worthwhile to report.

Change History

follow-up: ↓ 2   Changed 9 years ago by wichert

  • status changed from new to closed
  • resolution set to wontfix

I just checked the  official libhttpd soucrces and they do not support an extra r parameter either.

in reply to: ↑ 1   Changed 9 years ago by tj@…

Replying to wichert:

I just checked the  official libhttpd soucrces and they do not support an extra r parameter either.

True. The r parameter does not exist at all in the official libhttpd source, it appears to be a wifidog specific implementation. I assume the r parameter simply was not added to the preload, as it was to most every other libhttpd function, because the preload portion of the API is not used by wifidog.

I happen to be using it where I have different subnets for the wired lan and wireless lan in order to prevent wifi connected clients from accessing the custom administration pages I have on the router.

This ticket was more of an FYI than anything in case the preload functionality does get implemented in the official wifidog codebase in the future.

Note: See TracTickets for help on using tickets.