PATCH: Error parsing outgoing traffic in iptables_fw_counters_update()

[rgmarelli@…]

Hi, it seems that there is a formatting error when parsing outgoing traffic in iptables_fw_counters_update(). Current line only updates the outgoing counter of the first client. Line 503 is:

rt = fscanf(output, "%*s %llu %*s %*s %*s %*s %*s %15[0-9.] %*s %*s %*s %*s %*s 0x%*u", &counter, ip);

but should be:

rc = fscanf(output, "%*s %lu %*s %*s %*s %*s %*s %15[0-9.] %*s %*s %*s 0x%*u", &counter, ip);

Regards,

Guido

[jean-philippe.menil@…]

The workaround don't work.
This one work:
in fw_iptables.c line 536:
rt = fscanf(output, "%*s %llu %*s %*s %*s %*s %*s %15[0-9.] %*s %*s %*s %*s %*s 0x%*u", &counter, ip);
should be:
rt = fscanf(output, "%*s %llu %*s %*s %*s %*s %*s %15[0-9.] %*s %*s %*s %*s %*s %*s", &counter, ip);
Now all the counters are parsed correctly, and we don't have anymore the following message:
Messages: | Incoming or outgoing counter is missing; counters not updated. | User is now logged out.

[gbastien]

Implemented patch by Jean-Philippe Menil