Problem with spaces at network name

[anonymous]

I've created a new network with ID "PFC Network". Wifidog gave no error, but when I tried to modify network parameters, I get an error as "UPDATE networks SET name = where ...". The problem was the space in the ID.

I think it could be a good idea don't let people use invalid characters at ID fields.

Thanks...

[Robin Jones]

A Possible solution to this is as follows, replacing the current class in Network.php:

    /**
     * Process the new object interface.
     *
     * Will return the new object if the user has the credentials and the form
     * was fully filled.
     *
     * @return mixed The Network object or null if no new Network was created.
     *
     * @static
     * @access public
     */
    public static function processCreateNewObjectUI()
    {
        // Init values
        $retval = null;
        $name = "new_network_id";

        if (!empty($_REQUEST[$name])) {
            $network_id = $_REQUEST[$name];

            if (!preg_match('/^[0-9a-zA-Z_-]+$/', $network_id)) {
            echo  _("The Network ID entered was not valid. It must only contain Alphanumerical Characters, Hyphens and Underscores e.g. My_Network-6");
            return;
            }

            if ($network_id) {
                Security::requirePermission(Permission::P('SERVER_PERM_ADD_NEW_NETWORK'), Server::getServer());
                $retval = self::createNewObject($network_id);
            }
        }

        return $retval;
    }

Although we do need to think of a better way to perform error handling and form validation through the whole of the admin interface.

[benoitg]

Just blindly throw an exception with the error message, it will display prettyly (wifidog has a custom exception handler).

[Robin Jones]

Is this better?

 public static function processCreateNewObjectUI()
    {
        // Init values
        $retval = null;
        $name = "new_network_id";

        if (!empty($_REQUEST[$name])) {
            $network_id = $_REQUEST[$name];

            if (!preg_match('/^[0-9a-zA-Z_-]+$/', $network_id)) {
            throw new Exception(_("The Network ID entered was not valid. It must only contain Alphanumerical Characters, Hyphens and Underscores e.g. My_Network-6"));
            return;
            }

            if ($network_id) {
                Security::requirePermission(Permission::P('SERVER_PERM_ADD_NEW_NETWORK'), Server::getServer());
                $retval = self::createNewObject($network_id);
            }
        }

        return $retval;
    }

[networkfusion]

[1409]