Changeset 733

Timestamp:

09/10/05 15:39:51 (8 years ago)

Author:

aprilp

Message:

isset, and issues preventing users from logging out.

Location:

trunk/wifidog-auth

Files:

• ChangeLog (modified) (1 diff)
• wifidog/classes/Authenticator.php (modified) (2 diffs)
• wifidog/classes/Network.php (modified) (1 diff)
• wifidog/classes/Node.php (modified) (1 diff)

trunk/wifidog-auth/ChangeLog

@@ -2 +2 @@
         * signup.php: Fixed bug in detecting is the user is already part of the
         network.
+        * classes/{Authenticator,Network,Node}.php: isset, and issues preventing
+        users from logging out.
 
 2005-09-10 Francois Proulx <francois.proulx@gmail.com>

trunk/wifidog-auth/wifidog/classes/Authenticator.php

@@ -72 +72 @@
                         {
                                 //Try to destroy all connections tied to the current node
-                                $sql = "SELECT conn_id FROM connections WHERE user_id = '{$user->getId()}' AND node_id={$node->getId()} AND token_status='".TOKEN_INUSE."';\n";
+                                $sql = "SELECT conn_id FROM connections WHERE user_id = '{$user->getId()}' AND node_id='{$node->getId()}' AND token_status='".TOKEN_INUSE."';\n";
                         $conn_rows = null;
                                 $db->ExecSql($sql, $conn_rows, false);
@@ -129 +129 @@
                         $conn_rows = array ();
                         $db->ExecSql($sql, $conn_rows, true);
-                        foreach ($conn_rows as $conn_row)
-                        {
-                                $this->acctStop($conn_row['conn_id']);
-                        }
+                        if (isset($conn_rows)) {
+                foreach ($conn_rows as $conn_row)
+                            {
+                                    $this->acctStop($conn_row['conn_id']);
+                            }
+            }
                 }
 

trunk/wifidog-auth/wifidog/classes/Network.php

@@ -333 +333 @@
                         throw new Exception("Network::getAuthenticator():  Security error:  The parameters passed to the constructor of the authenticator are potentially unsafe");
                 }
-                $objstring = 'return new '.$this->mRow['network_authenticator_class'].'('.$this->mRow['network_authenticator_params'].');';
+                $objstring = 'return new '.$this->mRow['network_authenticator_class']."('".$this->mRow['network_authenticator_params']."');";
                 return eval ($objstring);
         }

trunk/wifidog-auth/wifidog/classes/Node.php

@@ -1163 +1163 @@
                 // Get all network, but exclude user subscribed content if asked
                 if ($exclude_subscribed_content == true && $subscriber)
-                        $sql = "SELECT content_id FROM node_has_content WHERE node_id='$this->id' AND content_id NOT IN (SELECT content_id FROM user_has_content WHERE user_id = '{$subscriber->getId()}') ORDER BY subscribe_timestamp DESC";
+                        $sql = "SELECT content_id FROM node_has_content WHERE node_id='{$this->id}' AND content_id NOT IN (SELECT content_id FROM user_has_content WHERE user_id = '{$subscriber->getId()}') ORDER BY subscribe_timestamp DESC";
                 else
-                        $sql = "SELECT content_id FROM node_has_content WHERE node_id='$this->id' ORDER BY subscribe_timestamp DESC";
+                        $sql = "SELECT content_id FROM node_has_content WHERE node_id='{$this->id}' ORDER BY subscribe_timestamp DESC";
                 $db->ExecSql($sql, $content_rows, false);