Changeset 311

Timestamp:

01/10/05 15:15:05 (8 years ago)

Author:

benoitg

Message:

2004-01-10 Benoit Gr�goire <bock@…>

• include/common.php: Fix SSL security warnings. If SSL is enabled and the page was actually served over SSL, all media in the file will be served over SSL. Add a new define (BASE_NON_SSL_PATH) to allow us to make links that break out of SSL mode. From now on, use the self adapting BASE_URL_PATH in most circumstance, BASE_SSL_PATH to enter SSL mode, and BASE_URL_PATH to break out of it.

Location:

trunk/wifidog-auth

Files:

• ChangeLog (modified) (1 diff)
• wifidog/include/common.php (modified) (2 diffs)

trunk/wifidog-auth/ChangeLog

@@ -1 +1 @@
 # $Header$
+2004-01-10 Benoit Gr�goire  <bock@step.polymtl.ca>
+        * include/common.php: Fix SSL security warnings.  If SSL is enabled and the page was actually served over SSL, all media in the file will be served over SSL. Add a new define (BASE_NON_SSL_PATH) to allow us to make links that break out of SSL mode.  From now on, use the self adapting BASE_URL_PATH in most circumstance, BASE_SSL_PATH to enter SSL mode, and BASE_URL_PATH to break out of it.
 2004-01-10 Benoit Gr�goire  <bock@step.polymtl.ca>
         * admin/user_stats.php: Add three top tens to the statistics:  Top ten apetite for bandwidth, top ten travelers, most addicted users.

trunk/wifidog-auth/wifidog/include/common.php

@@ -63 +63 @@
 
 /* This section deals with PATHs */
-define('BASE_URL_PATH', 'http://' . $_SERVER['HTTP_HOST'] . SYSTEM_PATH);
+define('BASE_NON_SSL_PATH', 'http://' . $_SERVER['HTTP_HOST'] . SYSTEM_PATH);
+
 if(SSL_AVAILABLE)
   {
@@ -70 +71 @@
 else
   {
-    define('BASE_SSL_PATH',BASE_URL_PATH);
+    define('BASE_SSL_PATH', BASE_NON_SSL_PATH);
+  }
+  
+  /* If we actually ARE in SSL mode, make all URLS http:// to avoid security warnings. */
+if(isset($_SERVER['HTTPS']))
+  {
+  define('BASE_URL_PATH', BASE_SSL_PATH); 
+  }
+  else
+  {
+  define('BASE_URL_PATH', BASE_NON_SSL_PATH);
   }