Changeset 1336

Timestamp:

03/15/08 19:15:30 (5 years ago)

Author:

benoitg

Message:

• Content.php: Eliminate the generation of a large number of useless SQL queries when getting Content metadata.
• User.php: Do the same thing for getCurrentUser()

Location:

trunk/wifidog-auth

Files:

• CHANGELOG (modified) (1 diff)
• wifidog/classes/Content.php (modified) (4 diffs)
• wifidog/classes/User.php (modified) (1 diff)

trunk/wifidog-auth/CHANGELOG

@@ -1 +1 @@
 # $Id$
+2008-03-15 Benoit Grégoire  <bock@step.polymtl.ca>
+        * Content.php:  Eliminate the generation of a large number of useless SQL queries when getting Content metadata.
+        * User.php: Do the same thing for getCurrentUser()
+        
 2008-03-12 Benoit Grégoire  <bock@step.polymtl.ca>
     * Major performance improvement in content manager for content groups picking items with limits on how many times they can be displayed.

trunk/wifidog-auth/wifidog/classes/Content.php

@@ -1070 +1070 @@
      */
     public function getTitle() {
-        try {
-            return self :: getObject($this->content_row['title']);
-        } catch (Exception $e) {
-            return null;
-        }
+        $retval = null;
+        if(!empty($this->content_row['title'])){
+            $retval = self :: getObject($this->content_row['title']);
+        }
+        return $retval;
     }
 
@@ -1082 +1082 @@
      */
     public function getDescription() {
-        try {
-            return self :: getObject($this->content_row['description']);
-        } catch (Exception $e) {
-            return null;
-        }
+        $retval = null;
+        if(!empty($this->content_row['description'])){
+            $retval = self :: getObject($this->content_row['description']);
+        }
+        return $retval;
     }
 
@@ -1094 +1094 @@
      */
     public function getLongDescription() {
-        try {
-            return self :: getObject($this->content_row['long_description']);
-        } catch (Exception $e) {
-            return null;
-        }
+        $retval = null;
+        if(!empty($this->content_row['long_description'])){
+            $retval = self :: getObject($this->content_row['long_description']);
+        }
+        return $retval;
     }
 
@@ -1106 +1106 @@
      */
     public function getProjectInfo() {
-        try {
-            return self :: getObject($this->content_row['project_info']);
-        } catch (Exception $e) {
-            return null;
-        }
+        $retval = null;
+        if(!empty($this->content_row['project_info'])){
+            $retval = self :: getObject($this->content_row['project_info']);
+        }
+        return $retval;
     }
 

trunk/wifidog-auth/wifidog/classes/User.php

@@ -104 +104 @@
         require_once ('classes/Session.php');
         $session = Session::getObject();
+        $sessCurrentUserId = $session->get(SESS_USER_ID_VAR);
         $user = null;
-        try {
-            $user = self :: getObject($session->get(SESS_USER_ID_VAR));
-            //$user = new User($session->get(SESS_USER_ID_VAR));
-        } catch (Exception $e) {
-            /**If any problem occurs, the user should be considered logged out*/
-            $session->set(SESS_USER_ID_VAR, null);
+        if(!empty($sessCurrentUserId)){
+            try {
+                $user = self :: getObject($sessCurrentUserId);
+                //$user = new User($session->get(SESS_USER_ID_VAR));
+            } catch (Exception $e) {
+                /**If any problem occurs, the user should be considered logged out*/
+                $session->set(SESS_USER_ID_VAR, null);
+            }
         }
         return $user;